Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queueMicrotask #106

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add queueMicrotask #106

merged 1 commit into from
Nov 21, 2023

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 21, 2023

Ref: #16

@saghul saghul requested a review from bnoordhuis November 21, 2023 14:53
bnoordhuis
bnoordhuis approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to test our implementation against https://github.com/web-platform-tests/wpt.

The main tests are in https://github.com/web-platform-tests/wpt/tree/master/html/webappapis/microtask-queuing and don't need a browser to run. There are more scattered across other directories.

quickjs.c Outdated Show resolved Hide resolved
quickjs.c Outdated Show resolved Hide resolved
@saghul saghul merged commit 8d496b3 into master Nov 21, 2023
19 checks passed
@saghul saghul deleted the queue-microtask branch November 21, 2023 22:43
@saghul
Copy link
Contributor Author

saghul commented Nov 21, 2023

I ported over some minimal test cases from WPT. More to come, we might want to think about some kind of test suite or are we ok with the current one?

@bnoordhuis
Copy link
Contributor

We may want to reconsider if/when we add more web platform APIs but until then I'm fine with cribbing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis